Fix TransactionBuilder failing to debug P2PKH-only transactions#318
Fix TransactionBuilder failing to debug P2PKH-only transactions#318rkalis merged 2 commits intoCashScript:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #318 +/- ##
==========================================
+ Coverage 97.36% 97.40% +0.03%
==========================================
Files 78 78
Lines 17920 17926 +6
Branches 1144 1336 +192
==========================================
+ Hits 17448 17461 +13
+ Misses 470 456 -14
- Partials 2 9 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks pat for this PR! We rebased and added some extra (skipped) tests. We realised that it would be nice to have proper evaluation also for P2PKH inputs, but that is currently not how the debugging tools work, so just skipping the debugging if it's only P2PKH (like you did here) makes a lot of sense. We did add some skipped tests and we have an issue (#323) that discusses improving the handling of P2PKH inputs in the future. |
2 participants
No description provided.